Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pprof: change debug 2 to debug 1 to avoid gc stw #7935

Closed
wants to merge 1 commit into from
Closed

pprof: change debug 2 to debug 1 to avoid gc stw #7935

wants to merge 1 commit into from

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Mar 18, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #7934

What is changed and how does it work?

can check more detail in pingcap/tidb#48695

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@HuSharp
avoid stw
951e179 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 18, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Mar 18, 2024

/check-issue-triage-complete

@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #7935 (951e179) into master (da3b6e3) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7935      +/-   ##
==========================================
- Coverage   73.54%   73.44%   -0.10%     
==========================================
  Files         436      436              
  Lines       48349    48349              
==========================================
- Hits        35558    35512      -46     
- Misses       9731     9770      +39     
- Partials     3060     3067       +7
Flag Coverage Δ
unittests 73.44% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@nolouch
Copy link
Contributor

nolouch commented Mar 18, 2024

It's better to keep consist with tidb pingcap/tidb#9651.
I think it's ok because it is only called manually.

@HuSharp
Copy link
Member Author

HuSharp commented Mar 19, 2024

It's better to keep consist with tidb pingcap/tidb#9651. I think it's ok because it is only called manually.

Close by this comment

@HuSharp HuSharp closed this Mar 19, 2024
@HuSharp HuSharp deleted the goroutine_debug branch March 19, 2024 01:53
@HuSharp HuSharp mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change debug=2 to debug=1 on goroutine profiling
3 participants
@HuSharp @nolouch @lhy1024